Skip to content

feat(ui): sync BatchDiffApproval styling with BatchFilePermission #4640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

feat(ui): sync BatchDiffApproval styling with BatchFilePermission #4640

merged 1 commit into from
Jun 13, 2025

Conversation

@samhvw8
Copy link
Contributor

@samhvw8 samhvw8 commented Jun 13, 2025 •
edited
Loading

Related GitHub Issue

Closes: #4639

Description

  • Add unified container with border and rounded corners
  • Remove individual item margins for consistent spacing
  • Align visual design between batch approval components
before after
image image

Test Procedure

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.
  • ✨ New Feature: Non-breaking change that adds functionality.
  • 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
  • 📚 Documentation: Updates to documentation files.
  • ⚙️ Build/CI: Changes to the build process or CI configuration.
  • 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • There are no new linting errors or warnings (npm run lint).
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
    • All tests pass locally (npm test).
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch

Important

Align BatchDiffApproval styling with BatchFilePermission by adding a unified container and adjusting spacing in BatchDiffApproval.tsx.

  • Styling Changes:
    • Add unified container with border, rounded-md, and p-1 classes in BatchDiffApproval.tsx.
    • Remove individual item margins for consistent spacing.
  • Component Alignment:
    • Align visual design between BatchDiffApproval and BatchFilePermission.

This description was created by Ellipsis for 355c38f. You can customize this summary. It will automatically update as commits are pushed.

@samhvw8
feat(ui): sync BatchDiffApproval styling with BatchFilePermission
355c38f 
- Add unified container with border and rounded corners
- Remove individual item margins for consistent spacing
- Align visual design between batch approval components
@samhvw8 samhvw8 requested review from cte, jr and mrubens as code owners June 13, 2025 12:17
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. UI/UX UI/UX related or focused labels Jun 13, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 13, 2025
daniel-lxs
daniel-lxs approved these changes Jun 13, 2025
View reviewed changes
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 13, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Jun 13, 2025
@hannesrudolph hannesrudolph added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jun 13, 2025
@mrubens mrubens merged commit 9eb9fab into RooCodeInc:main Jun 13, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 13, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 13, 2025
@samhvw8 samhvw8 deleted the fix/sync-style-batch-diff branch June 13, 2025 14:41
cte pushed a commit that referenced this pull request Jun 24, 2025
@samhvw8 @cte
feat(ui): sync BatchDiffApproval styling with BatchFilePermission (#4640
b01f8b7 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrubens mrubens mrubens approved these changes

@daniel-lxs daniel-lxs daniel-lxs approved these changes

@cte cte Awaiting requested review from cte cte is a code owner

@jr jr Awaiting requested review from jr jr is a code owner

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer PR - Needs Review size:M This PR changes 30-99 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Style in Multiple Apply diff and multiple read not sync

4 participants

@samhvw8 @mrubens @daniel-lxs @hannesrudolph